Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maven_jar should allow a testonly attribute #1407

Closed
pmbethe09 opened this issue Jun 15, 2016 · 1 comment
Closed

maven_jar should allow a testonly attribute #1407

pmbethe09 opened this issue Jun 15, 2016 · 1 comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request

Comments

@pmbethe09
Copy link
Member

The easiest example is:

maven_jar(
name = "junit_repo",
artifact = "junit:junit:4.12",
testonly = 1, # would be nice to add this
sha1 = "2973d150c0dc1fefe998f834810d68f278ea58ec",
)
@hermione521 hermione521 added type: feature request P3 We're not considering working on this, but happy to review a PR. (No assignee) category: extensibility > external repositories labels Jun 15, 2016
@kchodorow kchodorow mentioned this issue Jun 15, 2016
Closed
@kchodorow
Copy link
Contributor

Closing this in favor of #1410, reimplementing the maven_jar rule in Skylark (which should give us testonly "for free").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kchodorow @hermione521 @pmbethe09