Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop re-using a stash with --reuse_sandbox_directories when the reuse is itself more expensive than creating a new sandbox directory #20584

Closed
oquenchil opened this issue Dec 18, 2023 · 1 comment
Assignees
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Performance Issues for Performance teams type: bug

Comments

@oquenchil
Copy link
Contributor

This affects for example test actions where two spawns are run, the first spawn runs the test and the second spawn processes the output to create an xml file.

The second will try to use the same stash as the first but will first have to clean it up, in some cases having to remove thousands of files that aren't needed.

@oquenchil oquenchil added type: bug P2 We'll consider working on this in future. (Assignee optional) team-Performance Issues for Performance teams labels Dec 18, 2023
@oquenchil oquenchil self-assigned this Dec 18, 2023
@oquenchil oquenchil added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Sep 18, 2024
@oquenchil
Copy link
Contributor Author

For test actions (which have two spawns), special logic was already added to avoid reuse between the two different spawns. It's unlikely that this would provide any measurable benefit for regular actions.

@oquenchil oquenchil closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Performance Issues for Performance teams type: bug
Projects
None yet
Development

No branches or pull requests

1 participant