Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--override_repo flag for injecting override_repo #23879

Open
tpudlik opened this issue Oct 4, 2024 · 2 comments
Open

--override_repo flag for injecting override_repo #23879

tpudlik opened this issue Oct 4, 2024 · 2 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request

Comments

@tpudlik
Copy link
Contributor

tpudlik commented Oct 4, 2024

Description of the feature request:

override_repo allows overriding a repository created by a module extension. The FR is for a flag exposing this functionality, analogous to --override_module and --override_repository.

Actually, I thought something like --override_repository=module_repo_canonical_name+extension_name+repo_name=path might "just work", but if it does then I could not spell it right!

@Wyv

Which category does this issue belong to?

External Dependency

What underlying problem are you trying to solve with this feature?

The use cases for this are basically the same as for --override_module: just like developers want to be able to override a module from the command line, they want to be able to override repos created by module extensions.

A specific use case I have in mind are CI builders that use a different version of a CIPD package.

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Oct 4, 2024
@Wyverald
Copy link
Member

Wyverald commented Oct 4, 2024

The FR sounds fair to me.

Actually, I thought something like --override_repository=module_repo_canonical_name+extension_name+repo_name=path might "just work", but if it does then I could not spell it right!

This should just work. But obviously it would be a local_repository override.

@Wyverald
Copy link
Member

Wyverald commented Oct 4, 2024

Actually, a couple of problems with this idea:

  1. override_repo works by overriding a specific repo generated by a specific module extension. How do you propose that to be expressed via a flag?
  2. What should we call this flag? --override_repo would be way too similar to --override_repository.

@Wyverald Wyverald added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants