-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Bash and Python runfiles libraries out of Bazel #24219
base: master
Are you sure you want to change the base?
Conversation
973d791
to
46db68e
Compare
FYI @comius, let me know if you want to merge this as is (Bash + Python). |
It looks ok to me. |
@comius I updated the description, feel free to merge this. I will open a new PR for Java and C++. |
@bazel-io fork 8.0.0 |
@fmeum Can you please resolve the conflicts? Thanks! |
46db68e
to
006cf31
Compare
@iancha1992 Done! |
@fmeum Looks like one of the tests is failing |
@iancha1992 Looks like CI has trouble connecting to |
@iancha1992 I sent #24425 to fix this, I guess that the failing tests just aren't supposed to hit anything other than the mirror. |
006cf31
to
16818bb
Compare
4378c2f
to
30f2982
Compare
30f2982
to
c7d4613
Compare
@meteorcloudy The remaining failure is due to |
I don't think so, can we work around this in the test? This feature will just go way when we delete WORKSPACE. |
The Bash and Python runfiles libraries in
@bazel_tools
are replaced with aliases to@rules_<lang>//<lang>/runfiles
.