Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move C++ runfiles library out of Bazel #24393

Closed
wants to merge 4 commits into from
Closed

Move C++ runfiles library out of Bazel #24393

wants to merge 4 commits into from
+123 −1,722

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 19, 2024 •
edited
Loading

This requires adding @rules_cc//cc/runfiles to the list of targets that BAZEL_REPOSITORY_NAME is defined for.

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Rules-Java Issues for Java rules team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Nov 19, 2024
@fmeum fmeum marked this pull request as draft November 19, 2024 18:20
@fmeum fmeum marked this pull request as ready for review November 19, 2024 18:37
@fmeum fmeum requested a review from comius November 19, 2024 18:37
@fmeum fmeum force-pushed the drop-cc-runfiles-library branch 2 times, most recently from f6f650a to a43b78c Compare November 19, 2024 19:09
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 20, 2024

@comius CI is green

@comius
Copy link
Contributor

comius commented Nov 21, 2024

I suspect some problems during import, so let me import this myself.

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 22, 2024
@fmeum fmeum deleted the drop-cc-runfiles-library branch November 22, 2024 14:11
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 22, 2024

@iancha1992 Could you mark this for 8.1.0?

@iancha1992
Copy link
Member

@bazel-io fork 8.0.0

@bazel-io bazel-io mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius comius approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Rules-CPP Issues for C++ rules team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmeum @comius @iancha1992