Release - patch release 0.14.1

[dslomov]

A patch release of 0.14 (#5056) with a fix for #5336

[dslomov]

scripts/release/release.sh create 0.14.1 10a4de9 4b80f2455e7e49a95f3a4c9102a67a57dad52207

[dslomov]

I will cherry-pick a fix for #5308 into this patch release.

[meteorcloudy]

@lfpino

[dslomov]

rc2: scripts/release/release.sh create 0.14.1 10a4de9 4b80f2455e7e49a95f3a4c9102a67a57dad52207 6b1635279e8b33dc1ac505ac81825e38f8797a14

[dslomov]

rc2 published, downstream tests started: https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/293

[dslomov]

Some stuff in downstream projects fails, but they also fail in trunk pipelines in the same way.
WDYT @aehlig (current Bazel Sheriff)

[jmillikin-stripe]

I've got another cherrypick request: 4ec0a75 to fix a regression in the Skylark implementation of new_git_repository (#5146).

[dslomov]

4ec0a75 does not fix a regression - it is a functionality change, or am I missing something?

[dslomov]

Patch release is out: https://github.com/bazelbuild/bazel/releases/tag/0.14.1

[dslomov]

Ping @petemounce for Chocolatey
Ping @ilovezfs for Homebrew

[ilovezfs]

I've shipped 0.14.1 in Homebrew: Homebrew/homebrew-core#28804

[jmillikin-stripe]

4ec0a75 does not fix a regression - it is a functionality change, or am I missing something?

Long ago (June 2017) I noticed that new_git_repository was broken on MacOS for some repos (#3127), and got a fix merged (#3142).

It was broken again (regressed) by some refactoring in February 2018 (a22a287), but I didn't notice because the repo we needed the fix for had been pinned to an older Bazel version (0.11). We just tried to update it to 0.14.0 and it failed due to a name conflict between BUILD and build/, since the MacOS filesystem is case-insensitive.

[dslomov]

I see. I don't think this meets the bar for patch release for 0.14. Let's cherry pick it into 0.15 (#5057).
I can't help noticing that #3142 has no tests, hence the bug.

[jmillikin-stripe]

Yes, it's definitely my fault for not having tests there. I just hadn't thought there would be so much development velocity in that part of the code.

0.15 should be fine in terms of timeline, it looks like it's already in the RC process. Thanks for the cherrypick.

[petemounce]

0.14.1 out on chocolatey.

[hlopko]

Can this issue be closed now?

[meteorcloudy]

Yes.