Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation claims Bazel requires JDK8 #6557

Closed
katre opened this issue Oct 30, 2018 · 11 comments
Closed

Documentation claims Bazel requires JDK8 #6557

katre opened this issue Oct 30, 2018 · 11 comments
Assignees
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-Java Issues for Java rules type: documentation (cleanup)

Comments

@katre
Copy link
Member

katre commented Oct 30, 2018

Currently the install documents (at https://docs.bazel.build/versions/master/install-compile-source.html#bootstrap-unix-prereq) claim that Bazel works with JDK8, but this is no longer accurate. We need to update the docs to correctly explain the required JDK versions.

@cushon
Copy link
Contributor

cushon commented Oct 30, 2018

@lberki

It depends what "works with" means (--server_javabase, --host_javabase, or --javabase)? Have we decided which JDK versions are supported yet?

Those docs are talking about bootstrapping, and JDK 8 is probably still a fine choice for that. The issue in #6550 only affects the binaries without an embedded JDK.

@meisterT
Copy link
Member

@katre I just followed the steps in a docker container and it produced a working bazel binary.

@katre
Copy link
Member Author

katre commented Oct 31, 2018

@meisterT Was that comment supposed to be on a different issue?

@meisterT
Copy link
Member

No, the comment was meant to be on this issue. However, in the meantime I was made aware that while the bootstrap succeeds and the resulting binary can build C++, it cannot build Java.

Assigning to @lberki to clarify supported Java version before we spend any time here.

cc @iirina

@lberki
Copy link
Contributor

lberki commented Nov 6, 2018

Regrettably, bootstrapping does not work with JDK 9, at least on Ubuntu 16.04 and Bazel 0.18 (I just checked). So the instructions are indeed accurate.

@lberki lberki closed this as completed Nov 6, 2018
@lberki
Copy link
Contributor

lberki commented Nov 6, 2018

My bad -- actually, it does, except with 16.04 has a bug that makes openjdk-9-jdk not install correctly :(

@lberki lberki reopened this Nov 6, 2018
@baryluk
Copy link

baryluk commented Dec 1, 2018

In bootstraping doc, I also found that it uses openjdk-8-jdk package as an example, but I think it is better to use default-jdk-headless (Debian/Ubuntu) , and if needed it will install newer JDK. User will still need to verify it is at least JDK 8 or 9.

@ash2k
Copy link
Contributor

ash2k commented Dec 4, 2018

Contributing to Bazel page also needs to mention which JDK is needed. I had version 11 installed and tests were failing. I assumed that JDK is needed because Bazel prints that it couldn't find any JDK matching 1.8 requirement or something like that and tried it. It also didn't work. I gave up. Then I have accidentally discovered that JDK 9 is what is needed to test/build bazel and it worked. Very confusing experience. It was my very first bazel PR.

@lberki lberki added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed untriaged labels Mar 13, 2019
@Flamefire
Copy link
Contributor

Related issue: #6035

So:

It depends what "works with" means

The docu states clearly "JDK 8. You must install version 8 of the JDK. Versions other than 8 are not supported." but #6035 states that "--host_javabase= won't work anymore."

Especially building Bazel on Power9 is a PITA due to the Java dependency.

@comius comius added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) labels Nov 21, 2020
@sgowroji sgowroji added the team-Documentation Documentation improvements that cannot be directly linked to other team labels label Jan 11, 2023
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Mar 17, 2024
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-Java Issues for Java rules type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests

10 participants