Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starlark dictionary accepting NoneType for values? #8967

Closed
agoulti opened this issue Jul 23, 2019 · 1 comment
Closed

Starlark dictionary accepting NoneType for values? #8967

agoulti opened this issue Jul 23, 2019 · 1 comment

Comments

@agoulti
Copy link

agoulti commented Jul 23, 2019

Is Starlark dictionary meant to accept None values?

I've added a field of type Type.STRING_DICT and the following definition:

exec_properties = {
"container-image": "docker://gcr.io/gcp-runtimes/ubuntu_16_0_4@sha256:096632d8fb3e78fbd58ae6a2b25ed46020dc70e65d89bca774af6f7b2de6898c",
"OSFamily": None,
}

I get the following message:
ERROR: /usr/local/google/home/agoulti/examples/toolchain-resolution-example/BUILD:13:1: //:plain_platform: expected value of type 'string' for dict value element, but got None (NoneType)

@katre katre added P1 I'll work on this now. (Assignee required) team-Starlark type: bug untriaged and removed P1 I'll work on this now. (Assignee required) labels Jul 23, 2019
@agoulti
Copy link
Author

agoulti commented Jul 24, 2019

Got a clarification: this is not a language limitation, but the type. STRING_DICT does not accept Nulls. Part of the reason is that there are many different representations: --output={build|xml|proto}, which all need to have representations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants