env_sets not supported by action_config

[ptychu]

Description of the problem / feature request:

Adding env_sets to build actions by adding them to action_config is not supported as docs suggest. (cc-toolchain-config-reference, cc_toolchain_config_lib.bzl:141).

I'm not sure if problem is missing implementation, or misleading docs.

Feature requests: what underlying problem are you trying to solve with this feature?

I want to setup remote license server for my compiler. It's done by environment variable. Therefore I want to add some environment variables to every execution of build action, that uses this compiler. After reading the docs I have come to an understanding that action_config is what I should use in this situation.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Try to provide env_sets to action_config(). Quick comparison between action_config and feature source code is enough to see it's not implemented.

What operating system are you running Bazel on?

Windows.

What's the output of bazel info release?

release 0.28.0

Have you found anything relevant by searching the web?

Seems to be introduced in issue #5380. Commit: d2e02548768c8e61607a1317c7c4fee5b29131b2

[scentini]

Hm, I'll take a look to see if we want to support env_set in action-config, or treat this as a documentation issue. In the meantime, you can define a feature with the needed env_set, and use the implies attribute of action_config to automatically trigger the feature.

[ptychu]

@scentini, Thanks. I used feature as a workaround, but didn't come up with using implies! I'd be willing to prepare a pull request, when it's decided how you want to treat this issue.

[github-actions]

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

[github-actions]

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!