Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.bazeliskrc: Support Variable Expansion and Tilde Notation in Home Directory Paths #586

Closed
albertocavalcante opened this issue Jun 25, 2024 · 0 comments · Fixed by #587
Closed

.bazeliskrc: Support Variable Expansion and Tilde Notation in Home Directory Paths #586

albertocavalcante opened this issue Jun 25, 2024 · 0 comments · Fixed by #587
Labels
P2 We'll consider working on this in future. (Assignee optional)

Comments

@albertocavalcante
Copy link
Contributor

Currently if someone sets in .bazeliskrc the following home paths:

BAZELISK_HOME=$HOME/.bazelisk
BAZELISK_HOME=~/.bazelisk

It will invoke os.MkdirAll with the raw string, therefore creating a ./'$HOME' and ./'~' respectively.

I would like to propose supporting both tile and var expansions in the path. Will submit a PR.
@albertocavalcante albertocavalcante mentioned this issue Jun 25, 2024
Merged
@meteorcloudy meteorcloudy added the P2 We'll consider working on this in future. (Assignee optional) label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 We'll consider working on this in future. (Assignee optional)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.bazeliskrc: Add Support for Env Var and Tilde Expansion albertocavalcante/bazelisk
2 participants
@meteorcloudy @albertocavalcante