New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`[shell,batch]_commands` can silently fail. #1694

Open

UebelAndre opened this issue Jun 13, 2023 · 2 comments

Assignees

Contributor

UebelAndre commented Jun 13, 2023

Noticed on https://buildkite.com/bazel/rules-rust-rustlang/builds/8734#0188b4bf-9114-4a94-9319-62e42cc4610d for the new post commands and suspect it's the same case for startup commands. Any suggestions on how to fix?

Contributor Author

UebelAndre commented Jun 13, 2023

cc @meteorcloudy

Member

meteorcloudy commented Jun 13, 2023

Not sure, we do have fail_if_nonzero on by default, somehow the bash command exited with 0?
https://github.com/bazelbuild/continuous-integration/blob/master/buildkite/bazelci.py#L2645

meteorcloudy assigned meteorcloudy and unassigned meteorcloudy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment