Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kythe.io job #4

Closed
damienmg opened this issue Apr 1, 2016 · 12 comments
Closed

Add kythe.io job #4

damienmg opened this issue Apr 1, 2016 · 12 comments
Labels

Comments

@damienmg
Copy link
Contributor

damienmg commented Apr 1, 2016

No description provided.

@damienmg damienmg self-assigned this Apr 1, 2016
@damienmg
Copy link
Contributor Author

damienmg commented Apr 1, 2016

http://www.kythe.io/contributing for how to run kythe

Runs on Linux and OS X

problems:

  • add missing dependencies to the machines
  • tools/modules/configure.sh runs bazel so it's incompatible with the current way we create job

@schroederc fyi

@damienmg
Copy link
Contributor Author

damienmg commented Apr 1, 2016

tools/modules/configure.sh is pulling llvm and clang sources... but also requires binaries, why @shahms?

@shahms
Copy link

shahms commented Apr 1, 2016

We depend on the clang AST for the C++ indexer (and hence need the sources) and also need a compiler. @zrlk may know more.

@zrlk
Copy link

zrlk commented Apr 1, 2016

To which binaries are you referring? We use Clang to build our code and require some version of it to be available.

@damienmg
Copy link
Contributor Author

damienmg commented Apr 4, 2016

I need to apt-get install clang to build kythe, then kythe download clang source and build them...

@zrlk
Copy link

zrlk commented Apr 4, 2016

We build LLVM and Clang libraries for indexing near HEAD, but we rely on a versioned copy of the compiler--that we expect most developers to already have installed--to do the work.

@damienmg
Copy link
Contributor Author

damienmg commented Apr 5, 2016

Another issue with kythe: it's more than the biggest job we have on ci (tensorflow) but the refactor I am doing will also take care of that (as well as handling the configure.sh issue). It will take some weeks though.

@damienmg
Copy link
Contributor Author

Ok so the work on ci.bazel.io is done, we just need the modification to kythe for not needing to run bazel inside an external script then we can start adding the needed depedencies on the slave and add kythe.

@philwo
Copy link
Member

philwo commented Jan 11, 2018

Closing, as I'm currently not planning on adding more projects to our CI until we're in a more stable state.

@philwo philwo closed this as completed Jan 11, 2018
@achew22
Copy link
Member

achew22 commented May 6, 2019

@philwo, would it be possible to reopen this and add Kythe to the Bazel test suite? It might help prevent issues like bazelbuild/bazel#8226 and would help provide coverage over some of the more exotic Bazel APIs

@philwo
Copy link
Member

philwo commented May 6, 2019

Yep, @lberki also pinged me about this. It would be best to file a new issue with our "Adding a project to Bazel CI" template. If someone from the Kythe team could do it, this would be perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants