Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Mac host #1

Closed
ahumesky opened this issue Aug 31, 2022 · 4 comments
Closed

Add support for Mac host #1

ahumesky opened this issue Aug 31, 2022 · 4 comments
Assignees
@ahumesky
Labels
enhancement New feature or request P1

Comments

@ahumesky
Copy link
Collaborator

android_ndk_repository in rules.bzl is currently hard-coded for Linux.
@ahumesky ahumesky self-assigned this Aug 31, 2022
@ahumesky ahumesky added enhancement New feature or request P1 labels Aug 31, 2022
@cpsauer
Copy link
Contributor

cpsauer commented Sep 2, 2022

Thanks so much @ahumesky!
[Subscribing and will play around more just as soon as this lands.]

@keith
Copy link
Member

keith commented Sep 2, 2022

@ahumesky is this something you're planning on picking up or should someone from the community take it on?

@keith
Copy link
Member

keith commented Sep 2, 2022

❤️

@ahumesky
Copy link
Collaborator Author

ahumesky commented Sep 2, 2022

It looks like all that was needed was to select the right clang directory, and the host_system_name is no longer used, so that could just be deleted. I can build the example app on both linux and mac now.

@cpsauer cpsauer mentioned this issue Sep 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahumesky ahumesky

Labels
enhancement New feature or request P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@keith @cpsauer @ahumesky