Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios_framework and ios_static_framework do not allow .hpp headers #112

Closed
silvester747 opened this issue Oct 12, 2017 · 3 comments
Closed
Labels
P3 Would be nice, but probably next quarter at the earliest type: feature request New feature or request

Comments

@silvester747
Copy link

In some of our projects we create ios frameworks that expose .hpp headers. However this is currently not allowed in ios_framework and ios_static_framework.

I am proposing to change the hdrs attr for the ios_framework and ios_static_framework rules to also allow .hpp files.

@silvester747
Copy link
Author

I already have an active fork here: https://github.com/silvester747/rules_apple/tree/allow_hpp but I still need to add/extend the tests.

@sergiocampama
Copy link
Contributor

Sorry for the delay.

As described in this guide, ios_framework is a packaging solution, not a distributable solution, so headers do not make sense in that context.

For ios_static_framework, I believe adding the hpp to the list of possible extensions should do the trick. I'm not aware of any other implicit processing done to hpp files that would affect this solution, but I haven't used hpp files in this context.

Can you try this out?

@sergiocampama sergiocampama added P3 Would be nice, but probably next quarter at the earliest type: feature request New feature or request labels Mar 12, 2019
@keith
Copy link
Member

keith commented Oct 26, 2021

You can now us ios_dynamic_framework and friends for this, or the suggestion above

@keith keith closed this as completed Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Would be nice, but probably next quarter at the earliest type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants