Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strip_prefix_header to objc_library rule #173

Closed
ob opened this issue Apr 24, 2018 · 2 comments
Closed

Add strip_prefix_header to objc_library rule #173

ob opened this issue Apr 24, 2018 · 2 comments

Comments

@ob
Copy link
Contributor

ob commented Apr 24, 2018

I'm trying to add an external dependency (OCHamcrest) which has all of its includes as:

#include <OCHamcrest/Foo.h>

I was trying to remove the OCHamcrest prefix in my objc_library rule, but found it has no support for it. Is there another way of stripping the prefix without having to modify all files?

@ob ob changed the title Add strip_prefix_header to objc_library Add strip_prefix_header to objc_library rule Apr 24, 2018
@thomasvl
Copy link
Member

objc_library is currently a native rule in bazel, so you'll want to open this against bazel.

At some point in the future we may look at moving objc_library to skylark and bundling it here, but that isn't current something that I think anyone is looking at.

@ob
Copy link
Contributor Author

ob commented May 16, 2018

After doing some digging, I think bazelbuild/bazel#3712 is a better way. Closing this.

@ob ob closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants