-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace phantomjs for closure_js_test #469
Comments
Anything that's karma based + headless chrome sounds good to me. |
i would kill for karma / headless chrome |
I just reviewed an internal update that replaces closure_js_test with one based on rules_webtesting. We'd be happy to contribute it after it has some time to bake, assuming there's someone that could review and merge it. |
I also have created a replacement for @robfig I'll be happy to help reviewing your version. As usual, someone else needs to merge, though. |
@robfig Are you planning to contribute a replacement for phantomjs? |
I don't have the bandwidth at the moment, but I'm happy to share what we're using. Looking at it, I think it was just imported from somewhere, probably the rules_webtesting repo itself. I don't think you'd want to use it as-is https://gist.github.com/robfig/f97541158982b7fad3daa9ac9132acad |
I find that phantomjs renders closure_js_test rather limited in terms of web apis, it's hard to use, and the error messages aren't very good.
Is there any appetite for replacing phantomjs with some sort of headless chrome or other browser? Has anyone started on such work?
For those interested in seeing phantomjs go away, what alternative(s) would you like to see?
The text was updated successfully, but these errors were encountered: