Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace phantomjs for closure_js_test #469

Open
pcj opened this issue Feb 2, 2020 · 6 comments
Open

Replace phantomjs for closure_js_test #469

pcj opened this issue Feb 2, 2020 · 6 comments

Comments

@pcj
Copy link
Member

pcj commented Feb 2, 2020

I find that phantomjs renders closure_js_test rather limited in terms of web apis, it's hard to use, and the error messages aren't very good.

Is there any appetite for replacing phantomjs with some sort of headless chrome or other browser? Has anyone started on such work?

For those interested in seeing phantomjs go away, what alternative(s) would you like to see?

@gkdn
Copy link
Collaborator

gkdn commented Feb 3, 2020

Anything that's karma based + headless chrome sounds good to me.
See karma_web_test rules from node_js rules:
https://bazelbuild.github.io/rules_nodejs/Karma.html

@sgammon
Copy link
Contributor

sgammon commented Feb 12, 2020

i would kill for karma / headless chrome

@robfig
Copy link
Contributor

robfig commented Feb 12, 2020

I just reviewed an internal update that replaces closure_js_test with one based on rules_webtesting. We'd be happy to contribute it after it has some time to bake, assuming there's someone that could review and merge it.

@Yannic
Copy link
Contributor

Yannic commented Mar 1, 2020

I also have created a replacement for closure_js_test based on Selenium / rules_webtesting, but that's tied to some infra code and hard to open-source. It's also very complicated and responsible for a significant portion of the flakyness I'm seeing, so I don't think sure y'all even want to see my version ;). I've also recently started to look into solutions that don't run the tests in a full browser (e.g. what https://github.com/google/gjstest does). It looks promising, but it's understandably not suitable as drop-in replacement for closure_js_test.

@robfig I'll be happy to help reviewing your version. As usual, someone else needs to merge, though.

@gkdn
Copy link
Collaborator

gkdn commented Jul 18, 2020

@robfig Are you planning to contribute a replacement for phantomjs?

@robfig
Copy link
Contributor

robfig commented Jul 20, 2020

I don't have the bandwidth at the moment, but I'm happy to share what we're using. Looking at it, I think it was just imported from somewhere, probably the rules_webtesting repo itself. I don't think you'd want to use it as-is

https://gist.github.com/robfig/f97541158982b7fad3daa9ac9132acad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants