This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 692
Fail to use the toolchain_configure rule with its docker_target parameter #2170
Labels
Can Close?
Will close in 30 days unless there is a comment indicating why not
Comments
Had to change three things to get this working (am not allowed to make PRs)
|
pbecotte
added a commit
to pbecotte/rules_docker
that referenced
this issue
Mar 24, 2023
We have to update the configure parameter to actually use docker_target. Once that is setup, we have to make sure that the executable is added to the runfiles, and update the entrypoint script to find the built binary. This should resolve bazelbuild#2170
pbecotte
added a commit
to pbecotte/rules_docker
that referenced
this issue
Mar 24, 2023
We have to update the configure parameter to actually use docker_target. Once that is setup, we have to make sure that the executable is added to the runfiles, and update the entrypoint script to find the built binary. This should resolve bazelbuild#2170
12 tasks
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
github-actions
bot
added
the
Can Close?
Will close in 30 days unless there is a comment indicating why not
label
Jul 2, 2023
This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
🐞 bug report
Affected Rule
I fail to use the toolchain_configure rule with its docker_target parameter.
Is this a regression?
I don't think, I tried with previous versions of the rules and get the same error. In addition, I might have not understood correctly how to use the docker_target argument.
Description
I used Nix to define a docker target. I can successfully run docker using
bazel run @docker20//:bin/docker
Then, I try to use it to configure the docker toolchain with the docker_target argument (using this doc) as below:
and I get this error:
🔬 Minimal Reproduction
It relies on Nix as well, but I think it is more related to the docker toolchain as I can actually run docker using
bazel run @docker20//:bin/docker
🔥 Exception or Error
🌍 Your Environment
Operating System:
Linux
Output of
bazel version
:Bazelisk version: v1.8.1
Build label: 5.3.0
Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Aug 23 00:45:53 2022 (1661215553)
Build timestamp: 1661215553
Build timestamp as int: 1661215553
Rules_docker version:
I can run bazel run @docker20//:bin/docker version and get
Client:
Version: 20.10.2
API version: 1.40
Go version: go1.16.4
Git commit: v20.10.2
Built: Thu Jan 1 00:00:00 1970
OS/Arch: linux/amd64
Context: default
Experimental: true
Server: Docker Engine - Community
Engine:
Version: 19.03.12
API version: 1.40 (minimum version 1.12)
Go version: go1.13.10
Git commit: 48a66213fe
Built: Mon Jun 22 15:44:07 2020
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: 1.2.13
GitCommit: 7ad184331fa3e55e52b890ea95e65ba581ae3429
runc:
Version: 1.0.0-rc10
GitCommit: dc9208a3303feef5b3839f4323d9beb36df0a9dd
docker-init:
Version: 0.18.0
GitCommit: fec3683
Anything else relevant?
Looking at _toolchain_configure_impl, repository_ctx.attr.tool_target is used while tool_target is not in toolchain_configure attributes. I tried to override this locally using docker_target instead, but I get an other issue:
The text was updated successfully, but these errors were encountered: