Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must migrate rule.output to OutputGroupInfo #987

Closed
or-shachar opened this issue Jul 13, 2019 · 1 comment · Fixed by #988
Closed

Must migrate rule.output to OutputGroupInfo #987

or-shachar opened this issue Jul 13, 2019 · 1 comment · Fixed by #988

Comments

@or-shachar
Copy link
Contributor

or-shachar commented Jul 13, 2019 •
edited
Loading

Just checked bazel 28 with the flag --incompatible_no_rule_outputs_param and failed on rules_docker

ERROR: /private/var/tmp/_bazel_ors/e1cd358f405ae1d1a5186e8a38e284f5/external/io_bazel_rules_docker/container/bundle.bzl:86:21: parameter 'outputs' is deprecated and will be removed soon. It may be temporarily re-enabled by setting --incompatible_no_rule_outputs_param=false

I might try to solve and contribute but I wanted to have an open issue about it here:

See details here:
bazelbuild/bazel#7977
@or-shachar or-shachar changed the title Migrate rule.output to OutputGroupInfo Must migrate rule.output to OutputGroupInfo Jul 13, 2019
@or-shachar or-shachar mentioned this issue Jul 14, 2019
Merged
@Monnoroch
Copy link

This is not fixed in push.bzl.

@or-shachar or-shachar mentioned this issue Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust to OutputGroupInfo or-shachar/rules_docker
2 participants
@Monnoroch @or-shachar