-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gazelle does not pick up files added by patch #4086
Comments
Patches are applied after Gazelle is run, so this is expected. We could have "after Gazelle patches", but I'm not sure whether that's worth the complexity. How much larger is your patch due to this? |
If I'm understanding you correctly, are you asking how much we have to add to our patch to make it work? Like could we just add a section to the patch to add the missing line to the generated My team, and hopefully other teams, are not overly reliant on patching, so totally understand if this isn't a boundry case you plan to support. |
We could also just modify the patch to append the code to an existing file. In this case, we got the patch from the package maintainer. |
What version of rules_go are you using?
0.50.0
What version of gazelle are you using?
0.38.0
What version of Bazel are you using?
7.3.1
Does this issue reproduce with the latest releases of all the above?
Yes
What operating system and processor architecture are you using?
macOS
Any other potentially useful information about your toolchain?
What did you do?
Attepmted to apply this patch with the following directive after our
use_repo(go_deps,...
statement inMODULE.bazel
:What did you expect to see?
A successful build.
What did you see instead?
Gazelle does not seem to pick up the
docker_config.go
file added by the patch; manually adding it to the generatedBUILD.bazel
file solves the problem.The text was updated successfully, but these errors were encountered: