Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing support for passing options to KSP processors #1035

Open
idanakav opened this issue Sep 28, 2023 · 2 comments · May be fixed by #1036
Open

Missing support for passing options to KSP processors #1035

idanakav opened this issue Sep 28, 2023 · 2 comments · May be fixed by #1036

Comments

@idanakav
Copy link

KSP offers a way to pass options to processors, its done with the -P flag, for example:

-P plugin:com.google.devtools.ksp.symbol-processing:apoption=key=value

Since we don't have a dedicated attr for that and the existing kotlinc opts are not supporting -P it's impossible to pass those options to the KSP plugin.

We probably would want to allow declaring the options on both target and processor level.
@idanakav idanakav linked a pull request Sep 29, 2023 that will close this issue
Open
@restingbull
Copy link
Collaborator

Does KSP fall on unknown options?

@idanakav
Copy link
Author

idanakav commented Oct 3, 2023

Does KSP fall on unknown options?

In general , yes, since kotlinc will throw on unknown options, but in the case of apoptions it simply going to split by = and pass down the key values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for passing ksp options idanakav/rules_kotlin
2 participants
@idanakav @restingbull