Skip to content

Commit

Permalink
fix: use golden_file_test instead
Browse files Browse the repository at this point in the history
  • Loading branch information
thesayyn authored and alexeagle committed Aug 31, 2020
1 parent 8a3f9b0 commit 1ef6704
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 29 deletions.
9 changes: 9 additions & 0 deletions internal/node/_node_bin/node
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/bin/bash
export NP_PATCHED_NODEJS="/Users/thesayyn/Documents/bazel/rules_nodejs/internal/node/_node_bin"
export PATH="/Users/thesayyn/Documents/bazel/rules_nodejs/internal/node/_node_bin":$PATH
if [[ ! "${@}" =~ "node_patches.js" ]]; then
exec /private/var/tmp/_bazel_thesayyn/a9a36d475d03232bfeced54055fb3183/external/nodejs_darwin_amd64/bin/nodejs/bin/node --require "/Users/thesayyn/Documents/bazel/rules_nodejs/internal/node/node_patches.js" "$@"
else
exec /private/var/tmp/_bazel_thesayyn/a9a36d475d03232bfeced54055fb3183/external/nodejs_darwin_amd64/bin/nodejs/bin/node "$@"
fi

Original file line number Diff line number Diff line change
@@ -1,26 +1,20 @@
load("@build_bazel_rules_nodejs//:index.bzl", "pkg_web")
load("@npm_bazel_jasmine//:index.from_src.bzl", "jasmine_node_test")
load("//internal/golden_file_test:golden_file_test.bzl", "golden_file_test")

package(default_visibility = ["//visibility:public"])

pkg_web(
name = "pkg",
srcs = [
"index.html",
"index.js",
],
substitutions = {
"THIS_SHOULD_BE_REPLACED": "THIS_SHOULD_BE_REPLACED_WITH_THIS",
},
)

jasmine_node_test(
golden_file_test(
name = "test",
srcs = ["spec.js"],
data = [
"index_golden.html_",
":pkg",
],
tags = [
"fix-windows",
],
actual = ":pkg",
golden = "index_golden.js_",
)
1 change: 1 addition & 0 deletions internal/pkg_web/golden_test/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
const a = 'THIS_SHOULD_BE_REPLACED';
1 change: 1 addition & 0 deletions internal/pkg_web/golden_test/index_golden.js_
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
const a = 'THIS_SHOULD_BE_REPLACED_WITH_THIS';
2 changes: 1 addition & 1 deletion internal/pkg_web/pkg_web.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ _ATTRS = {
doc = """Files which should be copied into the package""",
),
"substitutions": attr.string_dict(
doc = """Key-value pairs which are replaced in all the files while building the package.""",
doc = """Key-value pairs are replaced in all files while building the package.""",
),
"_assembler": attr.label(
default = "@build_bazel_rules_nodejs//internal/pkg_web:assembler",
Expand Down
1 change: 0 additions & 1 deletion internal/pkg_web/test3/index.html

This file was deleted.

1 change: 0 additions & 1 deletion internal/pkg_web/test3/index_golden.html_

This file was deleted.

15 changes: 0 additions & 15 deletions internal/pkg_web/test3/spec.js

This file was deleted.

0 comments on commit 1ef6704

Please sign in to comment.