build: update to latest rules_webtesting commit to pickup windows fixes #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
approved these changes
Sep 16, 2019
gregmagolan
force-pushed
the
chore/update_rules_webtesting
branch
from
864fd96 to
b42844b
Compare
|
UPDATE: depending on a rules_webtesting commit doesn't work as that requires rules_go to built its metadata binary from source. we'll need to update to the next rules_webtesting release or, alternately, include both windows fixes in the patch we already have here. |
…windows fixes Cannot update to latest rules_webtesting commit as we need to depend on the release package which does not have a rules_go dependency. This patch can be removed once we update to the next rules_webtesting release.
gregmagolan
force-pushed
the
chore/update_rules_webtesting
branch
from
b42844b to
15e0832
Compare
|
Note: I verified manually the patch is applied correctly just to be safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to latest rules_webtesting commit to pick up two Windows fixes.
We are using a patch to pull in (1) at the moment so this PR also removes the patch.
Not having (2) is blocking the rules_nodejs update in angular/angular: angular/angular#32151
Other options are: