Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module_name linking creates invalid links in some cases #1411

Closed
jbedard opened this issue Dec 3, 2019 · 0 comments · Fixed by #1432
Closed

module_name linking creates invalid links in some cases #1411

jbedard opened this issue Dec 3, 2019 · 0 comments · Fixed by #1432

Comments

@jbedard
Copy link
Collaborator

jbedard commented Dec 3, 2019

Will try to collect and provide more info, but I think at minimum there's issues when. A lot of these cases overlap though:

Inconsistent sibling mappings (one name/dir different):

@foo/bar/a => /path/x
@foo/bar/b => /path/b
@foo/bar/c => /path/c

Inconsistent siblings mappings (one path having an extra entry):

@foo/bar/a => /path/x/a
@foo/bar/b => /path/b
@foo/bar/c => /path/c

Parent having an extra mapping:

@foo/bar => /path/other/lib
@foo/bar/a => /path/lib/a
@foo/bar/b => /path/lib/b
@foo/bar/c => /path/lib/c

Siblings with different link types:

@foo/bar/a => /path/lib/a (bin)
@foo/bar/b => /path/lib/b (src)
@foo/bar/c => /path/lib/c (bin)

Parent with different link type:

@foo/bar => /path/lib (src)
@foo/bar/a => /path/lib/a (bin)
@foo/bar/b => /path/lib/b (bin)
@foo/bar/c => /path/lib/c (bin)
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Dec 7, 2019
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Dec 7, 2019
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Dec 7, 2019
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Dec 7, 2019
jbedard added a commit to jbedard/rules_nodejs that referenced this issue Dec 18, 2019
alexeagle pushed a commit that referenced this issue Dec 18, 2019
…rectory clashes (#1432)

ensure all FS test cases have equivelent reduceModules cases
update fs module-name tests to test unique link fs-layouts, not unique module_name=>link conversions

Fixes #1411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant