Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup pkg_web#move_files #2159

Closed
alexeagle opened this issue Aug 31, 2020 · 1 comment
Closed

Cleanup pkg_web#move_files #2159

alexeagle opened this issue Aug 31, 2020 · 1 comment
Labels
cleanup Tech debt, resolving it improves our own velocity
Milestone

Comments

@alexeagle
Copy link
Collaborator

This helper function tries to be callable from either an action or an aspect, by following the Law of Demeter and not asking for the whole ctx object as a parameter.
However it feels like overkill and causes a bunch of extra documentation in that rule. We don't even mean for it to be public I imagine. We should track down usages, make it private (underscore prefix) and just read things we need from ctx

@alexeagle alexeagle added this to the 3.0 milestone Aug 31, 2020
@alexeagle alexeagle added the cleanup Tech debt, resolving it improves our own velocity label Aug 31, 2020
@alexeagle
Copy link
Collaborator Author

fixed in 815a3ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Development

No branches or pull requests

1 participant