Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

users shouldn't have to dep on @jasmine-core #2253

Closed
alexeagle opened this issue Oct 27, 2020 · 1 comment · Fixed by #2336
Closed

users shouldn't have to dep on @jasmine-core #2253

alexeagle opened this issue Oct 27, 2020 · 1 comment · Fixed by #2336
Assignees
@mattem
Labels
bug cleanup Tech debt, resolving it improves our own velocity
Milestone
3.0

Comments

@alexeagle
Copy link
Collaborator

This was recently added in 2c34857
@alexeagle alexeagle added this to the 3.0 milestone Oct 27, 2020
@mattem mattem added bug cleanup Tech debt, resolving it improves our own velocity labels Oct 29, 2020
@alexeagle alexeagle assigned alexeagle and mattem and unassigned alexeagle Nov 3, 2020
@mattem mattem linked a pull request Dec 8, 2020 that will close this issue
Remove jasmine-core as a peer dep for @bazel/concatjs #2336
Merged
@mattem
Copy link
Collaborator

mattem commented Dec 11, 2020

closed via #2336

@mattem mattem closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattem mattem

Labels
bug cleanup Tech debt, resolving it improves our own velocity
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Remove jasmine-core as a peer dep for @bazel/concatjs mattem/rules_nodejs
2 participants
@alexeagle @mattem