feat(cypress): cypress executable toolchain #2668
Conversation
mrmeku
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
|
Was just discussing today with @mattem how esbuild has a similar fetch problem. Seems like they could use a similar solution maybe with tool chains? |
mrmeku
force-pushed
the
cypress-again
branch
4 times, most recently
from
f0ef430 to
103bab5
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Would love to see this merged, anything blocking this at the moment? |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
mrmeku
force-pushed
the
cypress-again
branch
4 times, most recently
from
75883fe to
e191b1d
Compare
mrmeku
changed the title
mrmeku
force-pushed
the
cypress-again
branch
3 times, most recently
from
95a96d7 to
a37511c
Compare
|
@googlebot I consent. |
mrmeku
force-pushed
the
cypress-again
branch
2 times, most recently
from
6c33e73 to
8ed8351
Compare
This is a major refactor the cypress_repository rule Prior to this change, the cypress CLI from NPM was invoked to download the corresponding Cypress binary. This was bad for a number of reasons. Namely it was non cachable and did not match bazel's semantics for grabbing the right binary for a particular platform / architecture The new cypress_repositories rule, downloads binaries for all platforms from Cypress's CDN and uses bazel's select logic to use the appropriate one given a particular configuration.
This is a major refactor the cypress_repository rule Prior to this change, the cypress CLI from NPM was invoked to download the corresponding Cypress binary. This was bad for a number of reasons. Namely it was non cachable and did not match bazel's semantics for grabbing the right binary for a particular platform / architecture The new cypress_repositories rule, downloads binaries for all platforms from Cypress's CDN and uses bazel's select logic to use the appropriate one given a particular configuration.
This is a major refactor the cypress_repository rule
Prior to this change, the cypress CLI from NPM was invoked
to download the corresponding Cypress binary.
This was bad for a number of reasons. Namely it was non cachable
and did not match bazel's semantics for grabbing the right binary
for a particular platform / architecture
The new cypress_repositories rule, downloads binaries for all
platforms from Cypress's CDN and uses bazel's select logic
to use the appropriate one given a particular configuration.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The old repository rule
cypress_repositoryhas been removed and in its place is a newcypress_repositoriesrule. User's will swap out these rules and add aversionattribute to their newcypress_repositoriesworkspace rule with a version which matches their package.json version of cypress.