fix(esbuild): fix depending on testonly targets #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsoulanille
changed the title
mattsoulanille
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
|
Good catch, thanks! I think at the minimum we should propagate the |
mattem
approved these changes
Sep 27, 2021
mattsoulanille
added a commit
to tensorflow/tfjs
that referenced
this pull request
Sep 28, 2021
Make the default ts_library macro behave like pre-4.0 versions of rules_nodejs by automatically setting package_name to module_name if its not set. Temporarily mark webgl tests as not testonly to work around bazel-contrib/rules_nodejs#2984 until the next release. Add package_name to pkg_npm targets.
pyu10055
pushed a commit
to tensorflow/tfjs
that referenced
this pull request
Oct 13, 2021
Make the default ts_library macro behave like pre-4.0 versions of rules_nodejs by automatically setting package_name to module_name if its not set. Temporarily mark webgl tests as not testonly to work around bazel-contrib/rules_nodejs#2984 until the next release. Add package_name to pkg_npm targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Fix esbuild error when depending on testonly targets.
What is the current behavior?
When an esbuild target with non-empty
argsis marked astestonly, it does not mark itsparams_fileas testonly. This causes the following error when it depends on anothertestonlytarget:Issue Number: N/A
What is the new behavior?
No error.
Does this PR introduce a breaking change?
Other information