refactor: depend on bazel-skylib at runtime #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
gregmagolan,
mattem,
mrmeku and
soldair
as code owners
This allows us to always publish regular bzl_library targets. We can also stop carefully vendoring skylib and shipping our own copy. Eventually we would run into a provider problem, where our vendored copy doesn't have the same provider symbol as the real repo. BREAKING CHANGE: build_bazel_rules_nodejs now depends on bazel_skylib. You can install it in your WORKSPACE directly, or use our helper macro like so:
alexeagle
force-pushed
the
dep_on_skylib
branch
from
950146c to
c6643c9
Compare
gregmagolan
reviewed
Nov 1, 2021
| @@ -25,6 +25,10 @@ http_archive( | |||
| urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/4.4.0/rules_nodejs-4.4.0.tar.gz"], | |||
| ) | |||
|
|
|||
| load("@build_bazel_rules_nodejs//nodejs:repositories.bzl", "rules_nodejs_dependencies") | |||
There was a problem hiding this comment.
I've seen this pattern around. rules_docker uses it
load("@build_bazel_rules_nodejs//nodejs:repositories.bzl", rules_nodejs_dependencies = "dependencies")
rules_nodejs_dependencies()
It avoids the unnecessary scoping in the rnj repo. Wdyt?
There was a problem hiding this comment.
rules_docker:
load(
"@io_bazel_rules_docker//repositories:repositories.bzl",
container_repositories = "repositories",
)
container_repositories()
There was a problem hiding this comment.
I think it makes users use the re-assignment syntax in the load statement that they may not have seen, and is overall more complex to have a second name for the thing (some users might not re-assign)
There was a problem hiding this comment.
rules_docker kinda needs it since they have so many language ecosystems to namespace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to always publish regular bzl_library targets. We can also stop carefully vendoring skylib and shipping our own copy.
Eventually we would run into a provider problem, where our vendored copy doesn't have the same provider symbol as the real repo.
BREAKING CHANGE:
build_bazel_rules_nodejs now depends on bazel_skylib.
You can install it in your WORKSPACE directly, or use our helper macro like so: