Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nextjs example #2068

Closed
wants to merge 2 commits into from
Closed

Nextjs example #2068

wants to merge 2 commits into from

Conversation

alexeagle
Copy link
Collaborator

No description provided.

Alex Eagle added 2 commits July 22, 2020 15:14
feat(examples): initial checkin of next.js example
ee9367b 
Ran npm init next-app nextjs-blog --example https://github.com/vercel/next-learn-starter/tree/master/data-fetching-starter
feat(examples): begin porting nextjs build to Bazel
54ec88c 
Fails with
./styles/global.css
Global CSS cannot be imported from files other than your Custom <App>. Please move all global CSS imports to pages/_app.js.
Read more: https://err.sh/next.js/css-global
Location: pages/_app.js

See bazel-contrib#2066
@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Sep 21, 2020
@mrtnzlml
Copy link

Hi @alexeagle, just wanted to check-in. Did you have any luck with Bazel vs. Next.js? :) Would you happen to know how to overcome the issues blocking this PR?

@alexeagle alexeagle removed the Can Close? We will close this in 30 days if there is no further activity label Oct 16, 2020
@flolu
Copy link
Contributor

flolu commented Mar 26, 2021

Any updates on this? I think Next.js example would be highly valuable

@flolu flolu mentioned this pull request Mar 26, 2021
Closed
@alexeagle
Copy link
Collaborator Author

So far it just hasn't been either funded by a company that needs it, or a fun hobby for someone in their spare time. Would love to work on this if some company needs it

@flolu
Copy link
Contributor

flolu commented Mar 27, 2021

Makes sense. What do you think is the estimated effort? (a couple days, weeks?)
We could add some funding, but our budget is small.

@alexeagle
Copy link
Collaborator Author

Hard to say, I don't think we even identified all the issues. Depends what other assumptions are broken by next tooling. ts_project took me about two weeks I think.

@flolu
Copy link
Contributor

flolu commented Mar 29, 2021

Btw the implementation with auto-generated next does work without write_chdir_script now.
But the global styles issue is still there. Other than that it works quite good, even with PWA support.

Do you think this is a bug in the next builder, or is there something "wrong" with Bazel?

@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Jun 28, 2021
@github-actions
Copy link

This PR was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

@github-actions github-actions bot closed this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattem mattem Awaiting requested review from mattem mattem will be requested when the pull request is marked ready for review mattem is a code owner

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan will be requested when the pull request is marked ready for review gregmagolan is a code owner

Assignees
No one assigned
Labels
Can Close? We will close this in 30 days if there is no further activity cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeagle @mrtnzlml @flolu @googlebot