docs(typescript): add host
configuration to rootDirs
#2401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
host
root directory is necessary for TypeScript to resolve imports for a tool executed at build time withcfg = "host"
.This is necessary for:
Because Bazel will build the tool in the
host
configuration, meaning generated *.js files will be dropped intobazel-out/host/bin/...
, andtsc
needs to know to look for dependentts_project()
outputs in that directory.Arguably a similar change is also necessary for
cfg = "exec"
, however files would be inbazel-out/k8-opt-exec-*/bin
, which can't be easily hard-coded in a tsconfig, so that's a problem to be tackled separately.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information
While not a breaking change, many users are likely to have copy-pasted this content from the docs and will not easily discover this information or update their
tsconfig.json
file. This could add additional confusion due to a difference between new projects which copy-paste this content, and old projects which already did.