Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When bazel issue 11164 is fixed, finish support for stamp attribute #340

Closed
aiuto opened this issue May 3, 2021 · 1 comment
Closed

When bazel issue 11164 is fixed, finish support for stamp attribute #340

aiuto opened this issue May 3, 2021 · 1 comment
Labels
p4 An idea that we are not considering working on at this time.

Comments

@aiuto
Copy link
Collaborator

aiuto commented May 3, 2021 •
edited
Loading

In the code that enables stamp, there are some hacks to detect the --stamp setting in a portable way.
When bazelbuild/bazel#11164 is fixed, go back and fix those TODOs
@aiuto aiuto added the P3 An issue that we are not working on but will review quarterly label May 3, 2021
@aiuto aiuto added this to the 1.1 milestone May 3, 2021
@aiuto aiuto removed this from the 1.1 milestone Jun 10, 2021
@aiuto aiuto added p4 An idea that we are not considering working on at this time. and removed P3 An issue that we are not working on but will review quarterly labels Mar 6, 2022
@aiuto
Copy link
Collaborator Author

aiuto commented Oct 7, 2022

Closing issues that no one is likely to work on for any foreseeable future.

We'll all know when --stamp is added to starlark in Bazal. Then this is pretty easy.

@aiuto aiuto closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p4 An idea that we are not considering working on at this time.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aiuto