You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Does setting the mode work with pkg_files | pkg_tar?
Im presuming this means passing a pkg_files target to a pkg_tar's srcs, and setting the attributes in pkg_files instead. I can confirm that does indeed seem to work 🙂
Noticed after updating from 0.8.1 to 0.10.1, and narrowed down to most likely being as a result of #756, specifically the following line, https://github.com/bazelbuild/rules_pkg/blob/main/pkg/private/pkg_files.bzl#L411, its no longer possible to set a mode for executable files via the
mode
attribute onpkg_tar
, as it gets forced to 0o755.Non-executable files can still be set, as their values don't end up in the manifest (and the manifest takes preference over flags to build_tar.py) due to the default_mode being set to None.
This makes it impossible for us to set a more restrictive mode of 0o555 on executable files.
The text was updated successfully, but these errors were encountered: