Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_wrapper does not substitute in param files #1536

Closed
roman-kashitsyn opened this issue Aug 31, 2022 · 0 comments · Fixed by #1565
Closed

process_wrapper does not substitute in param files #1536

roman-kashitsyn opened this issue Aug 31, 2022 · 0 comments · Fixed by #1565
Labels

Comments

@roman-kashitsyn
Copy link
Contributor

Sometimes rules_rust issues rustc commands with command line flags stored in.params files:

[
  "bazel-out/k8-opt-exec-2B5CBBC6/bin/external/rules_rust/util/process_wrapper/process_wrapper",
  "--arg-file",
  "bazel-out/k8-opt/bin/external/crate_index__serde-1.0.144/serde_build_script.linksearchpaths",
  "--subst",
  "pwd=${pwd}",
  "--",
  "bazel-out/k8-opt/bin/external/rust_linux_x86_64__x86_64-unknown-linux-gnu_tools/rust_toolchain/bin/rustc",
  "@bazel-out/k8-opt/bin/rs/scenario_tests/e2e-test-driver-0.params"
]

However, there is no logic in process_wrapper to substitute ${pwd} in @*.params arguments. This can result in non-deterministic build artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants