Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace obsolete markup-faces to adoc-faces #25

Closed
dunmaksim opened this issue Dec 26, 2022 · 2 comments · Fixed by #27
Closed

Replace obsolete markup-faces to adoc-faces #25

dunmaksim opened this issue Dec 26, 2022 · 2 comments · Fixed by #27

Comments

@dunmaksim
Copy link

Package markup-faces is obsolete (latest update 8 years ago). Main idea -- customization font faces for adoc-mode like faces for markdown-mode: https://github.com/jrblevin/markdown-mode/blob/master/markdown-mode.el#L1827
@bbatsov
Copy link
Owner

bbatsov commented Dec 26, 2022

I agree this would be better. It's not a lot of work, as the old adoc-mode faces are still in the code as obsolete variables (they were made obsolete when the markup-faces packages was created), so it's just a matter of swapping them for the faces coming from markup-faces. PR welcome!

@bbatsov
Copy link
Owner

bbatsov commented Dec 26, 2022

See https://github.com/bbatsov/adoc-mode/blob/master/adoc-mode.el#L269 for details.

@dunmaksim dunmaksim mentioned this issue Mar 2, 2023
Merged
@bbatsov bbatsov closed this as completed in 7012401 Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove markup-faces from code dunmaksim/adoc-mode
2 participants
@bbatsov @dunmaksim