Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-projectile-grep not respecting projectile-globally-ignored-file-suffixes #148

Open
clayliddell opened this issue Jun 25, 2020 · 3 comments

Comments

@clayliddell
Copy link

Expected behavior

When searching for a file using helm-projectile-grep, files with a suffix matching projectile-globally-ignored-file-suffixes should not appear in results.

Actual behavior

Files containing the ignored suffixes appear in the results.

Steps to reproduce the problem

  1. Create a file with a unique suffix inside of a projectile project.
  2. Inside the file place "test".
  3. Add your unique file suffix to 'projectile-globally-ignored-file-suffixes'.
  4. use help-projectile-grep to search for files containing "test" and confirm that the file created in step 1 appears.

Environment & version information

  • helm-projectile version: 20200615.527
  • helm version (in helm-pkg.el): 20200623.1058
  • projectile version (M-x projectile-version): 2020616.1659
  • Emacs version (M-x emacs-version): 26.3
  • OS: Ubuntu 18.04
@clayliddell clayliddell changed the title helm-projectile-grep ignoring projectile-globally-ignored-file-suffixes helm-projectile-grep not respecting projectile-globally-ignored-file-suffixes Jun 25, 2020
@obar
Copy link
Contributor

obar commented Jun 26, 2020

Have you tried ripgrep via helm-projectile-rg? Take a look at #61 for the background, you'd need to install the ripgrep (rg) binary on your system as well as the elisp package helm-rg. The plus side is, it's very fast.

@clayliddell
Copy link
Author

@obar Thanks for the suggestion! I'll have to check that out. I'll report my success here once I've given it a go.

@clayliddell
Copy link
Author

So, I ended up using ripgrep; however, I was having a bit much trouble getting helm-rg to work properly, and the project appears to be abandoned, so instead I'm just using helm-ag and helm-project-do-ag in conjunction with ripgrep under the hood. Sadly I was unable to get helm-projectile-ag to work properly due to #58; however helm-project-do-ag seems to satisfy my needs at the moment.

I would still consider this to be a bug with helm-projectile so I'm leaving this ticket open for record keeping sake. Thanks again for the suggestion @obar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants