What is the best way to disable prelude-python-mode-set-encoding?

[ryukinix]

That feature it's annoying to be used on python3 because it's no longer necessary. On the current year, 2020, python2 is officially deprecated. I know that adding this prevents people using python2 having problem, but is not my case. I'm having problem to get my work accepted sometimes because I have that auto inserted line:

# coding: utf-8

In general is unrelated to the patch I sent and frequently on code review is requested to delete this. (unnecessary headaches)

So I'm asking how I can disable that auto-insertion using prelude-python module properly without the need to hack my own prelude version and giving me problems to update later. Currently, I just deleted that line:

prelude/modules/prelude-python.el

Line 100 in 041617e

(add-hook 'after-save-hook 'prelude-python-mode-set-encoding nil 'local))

But is not optimal. It would better if it have a variable to turn it off.

[bbatsov]

Probably we should add a defcustom for this and disable it by default.

In the mean time you can just use remove-hook in your personal config.

[ryukinix]

In the mean time you can just use remove-hook in your personal config.

I tried that but didn't worked as expected, because that hook is inserted by another python hook here everytime that a buffer open:

prelude/modules/prelude-python.el

Lines 104 to 105 in 041617e

	(add-hook 'python-mode-hook (lambda ()
	(run-hooks 'prelude-python-mode-hook)))

So I would need to remove the entire prelude-python-mode-hook to get a effective change.

Probably we should add a defcustom for this and disable it by default.

I agreed. If I made a PR, do you will accept it?

[bbatsov]

Sure.

[ryukinix]

Ok, I'll fix it.

[ryukinix]

One doubt @bbatsov to make our code review easier later.

Probably we should add a defcustom for this and disable it by default.

1. You mean something like prelude-python-mode-set-encoding-toggle and be nil as default, right? That way the default behavior will not insert # coding: utf-8 anymore.

2. You mean prelude-python-mode-set-encoding-disable and be nil as default?

Can you confirm to me what option do you prefer?

[bbatsov]

I meant 1)

I'd name the defcustom prelude-python-mode-set-encoding-automatically.

[ryukinix]

Thanks for answer it! Good name.

[ryukinix]

PR submitted, @bbatsov. Review it when you can.