Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LineEndConcatenation to handle chained concats #1006

Closed
wants to merge 1 commit into from

Conversation

barunio
Copy link
Contributor

@barunio barunio commented Apr 15, 2014

This fixes an issue where the LineEndConcatenation cop wasn't able to detect or autocorrect multiple offenses for chained string concatenations.


def terminal_node_is_string_type?(node)
if node.type == :send
_, method, arg = *node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arg is actually first_arg.

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 18, 2014

@barunio You'll also have to rebase on top of the current master.

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 27, 2014

@barunio Ping :-)

@barunio
Copy link
Contributor Author

barunio commented Apr 27, 2014

Sorry, I got completely busy last week and am on vacation this week. I
might get a few minutes to push changes but most likely I'll finish this
(and the other pr I had opened) next weekend.

On Sunday, April 27, 2014, Bozhidar Batsov notifications@github.com wrote:

@barunio https://github.com/barunio Ping :-)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1006#issuecomment-41490469
.

Barun Singh
Founder & CTO
WegoWise.com

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 29, 2014

@barunio No worries. I've merged your PR manually.

@bbatsov bbatsov closed this Apr 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants