Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for SpaceBeforeBlockParameters: false with new lambda syntax #1197

Closed
padde opened this issue Jul 7, 2014 · 6 comments
Closed
Assignees
Labels

Comments

@padde
Copy link

padde commented Jul 7, 2014

# .rubocop.yml

Style/SpaceInsideBlockBraces:
  SpaceBeforeBlockParameters: false

checking the following code:

->(x) { x }

produces a false positive:

Inspecting 1 file
C

Offenses:

test.rb:1:8: C: Space between { and | detected.
->(x) { x }
@jonas054 jonas054 self-assigned this Jul 7, 2014
@jonas054
Copy link
Collaborator

jonas054 commented Jul 7, 2014

I'll try to fix it.

@jonas054 jonas054 added the bug label Jul 7, 2014
bbatsov added a commit that referenced this issue Jul 7, 2014
[Fix #1197] Deal with new lambda syntax in SpaceInsideBlockBraces
@padde
Copy link
Author

padde commented Jul 8, 2014

@jonas054 thanks a bunch! Looking forward to the next release...

@padde
Copy link
Author

padde commented Aug 13, 2014

@jonas054 we currently have many ugly rubocop comments in our codebase and are desperately waiting for this fix. Do you happen to know when the next release is planned? Thanks!

@jonas054
Copy link
Collaborator

It's up to @bbatsov to decide.

@bbatsov
Copy link
Collaborator

bbatsov commented Aug 13, 2014

The release should happen soon. There are a few open PRs that I'd like us to wrap before we can proceed with the release.

@padde
Copy link
Author

padde commented Aug 13, 2014

@jonas054 @bbatsov thanks for your quick replies and keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants