Ignore block-pass in TrailingComma
#1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| ### Bugs fixed | |||
|
|
|||
| * [#1256](https://github.com/bbatsov/rubocop/issues/1256): Ignore block-pass in `TrailingComma`. ([@tamird][]) | |||
There was a problem hiding this comment.
This line should be at the bottom of entry.
|
Coverage increased (+0.0%) when pulling 584642bb46e0fecede0bd52c89afe427de77eb16 on tamird:trailing-commas-block into 5a5215b on bbatsov:master. |
| @@ -127,7 +127,10 @@ def avoid_comma(kind, comma_begin_pos, sb, extra_info) | |||
| end | |||
|
|
|||
| def put_comma(items, kind, sb) | |||
| last_expr = items.last.loc.expression | |||
| item = items.last | |||
There was a problem hiding this comment.
Wouldn't last_item be a better name here?
Trailing commas after a block-pass are a parse error, so we must special-case them.
bbatsov
added a commit
that referenced
this pull request
Aug 9, 2014
Ignore block-pass in `TrailingComma`
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trailing commas after a block-pass are a parse error, so we must
special-case them. @yous @bbatsov