Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opal likes multiline %x{} #1397

Closed
lloeki opened this issue Oct 20, 2014 · 4 comments · Fixed by #1655
Closed

Opal likes multiline %x{} #1397

lloeki opened this issue Oct 20, 2014 · 4 comments · Fixed by #1655

Comments

@lloeki
Copy link
Contributor

lloeki commented Oct 20, 2014

Style/UnneededPercentX could use a variant preferring %x{} to backticks when multiline is used.

This is especially useful for Opal, which uses backticks and percent X to go down to JavaScript.

@lloeki
Copy link
Contributor Author

lloeki commented Dec 31, 2014

A quick note that this would also be useful for Homebrew, along with a variant imposing use of %x{} even for single-line.

@bbatsov
Copy link
Collaborator

bbatsov commented Dec 31, 2014

Sure. I think your suggestion is pretty sensible, but I'm super busy and I
won't be able to implement this soon.

On Wednesday, December 31, 2014, Loic Nageleisen notifications@github.com
wrote:

A quick note that this would also be useful for Homebrew.


Reply to this email directly or view it on GitHub
#1397 (comment).

@lloeki
Copy link
Contributor Author

lloeki commented Dec 31, 2014

No problem, I was just adding the new use case about %x{} everywhere.

@bquorning
Copy link
Contributor

Suggested fix in #1655.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants