Style/Alias doesn't allow any use of alias

[marxarelli]

According to comments in rubocop/ruby-style-guide#377 alias is not strictly forbidden by the style guide and in fact can be more appropriate than alias_method in some cases—usually those involving lexical scope and a clear indirection to methods within the same scope. The Style/Alias cop needs refactoring to allow the use of alias in cases such as the following.

class Westerner
  def first_name
    @names.first
  end

  alias given_name first_name
end

[bf4]

I see the PR wasn't merged.

In 0.35.1 I'm still getting that annoying Style/Alias: Use alias_method instead of alias. (https://github.com/bbatsov/ruby-style-guide#alias-method) even though https://github.com/bbatsov/ruby-style-guide#alias-method-lexically it should be permitted. And the only option is Enabled.

I don't really understand cop internals, so I can't tell what it's doing wrong.

[bbatsov]

@marxarelli disappeared and I didn't have time to work on this myself. Someone else will have to drive the work here to completion.

Basically, now the cop reflects an older version of the style guide.

[bf4]

I'm happy to help with some guidance.. I understand the ruby and the parser, but would need some help getting that into a tested coo

B mobile phone

On Dec 9, 2015, at 4:00 AM, Bozhidar Batsov notifications@github.com wrote:

@marxarelli disappeared and I didn't have time to work on this myself. Someone else will have to drive the work here to completion.

Basically, now the cop reflects an older version of the style guide.

—
Reply to this email directly or view it on GitHub.

[bbatsov]

Sure. You can start work on this and we'll lend you all the help you need.

[bf4]

@alexdowad Yay! 🌈 ❤️ ✨ 💯

[marxarelli]

Sorry about being a total flake on this one. I'm glad it got done by @alexdowad !

[matrinox]

I think the default should be prefer_alias_method. That was the behaviour before and upgrading a minor release should not break that expectation.

[bbatsov]

See https://github.com/bbatsov/rubocop#installation