EmptyLinesAroundAccessModifier: autocorrect hangs on a function that looks like a modifier

[dblock]

class Hello
  def public
    true
  end

  def foo?
    public
  end
end

Tries to align public back and forth. Still working on a spec.

[dblock]

Spec: dblock@01c4b7d

TBH I don't see how to fix it, but in this case AccessModifierNode#modifier_node? is returning the wrong thing. One idea could be to walk the parent tree and make sure we're not in a :def, but seems iffy to me. Ideas?

[jonas054]

Checking that the parent is a :class or :module node seems like the right thing to do. Or normally the grandparent as there will be a :begin node in-between if the modifier isn't the only member of the class/module.

[dblock]

Made a bit of progress in dblock@565b603, only one spec to go.

  1) RuboCop::Cop::Style::AccessModifierIndentation when EnforcedStyle is set to outdent auto-corrects private in complicated case
     Failure/Error: expect(corrected).to eq(['class Hello',

       expected: "class Hello\n  def foo\n    'hi'\n  end\n\n  def bar\n    Module.new do\n\n    private\n\n      def hi\n        'bye'\n      end\n    end\n  end\nend"
            got: "class Hello\n  def foo\n    'hi'\n  end\n\n  def bar\n    Module.new do\n\n     private\n\n      def hi\n        'bye'\n      end\n    end\n  end\nend"

       (compared using ==)

       Diff:
       @@ -6,7 +6,7 @@
          def bar
            Module.new do

       -    private
       +     private

              def hi
                'bye'

This one is harder, we have a block that creates a Module (or a class). The AST is like this:

(block
  (send
    (const nil :Module) :new)
  (args)
  (begin
    (send nil :private)
    (def :hi
      (args)
      (str "bye"))))

Is there already a way to identify things like these before I reinvent the wheel?

[dyatlov]

Running rubocop -a on a code bellow and it hangs. Private goes up and down.. Body beginning and accessor spaces are conflicting

# private methods
module AnswerPrivateMethods
  extend ActiveSupport::Concern

  included do
    private

    def some_method
        puts "boo"
    end
  end
end

[dblock]

Yes @dyatlov that's what I am trying to fix.

[jonas054]

@dblock Take a look at AccessModifierIndentation#class_constructor?. I think you should move it to the AccessModifierNode module and reuse it.

[dblock]

That worked, thanks @jonas054. PR #1491.

[dblock]

I PRed a solution to prevent future infinite loops in #1492.