Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cop warning about capybara debug methods #1507

Closed
lloeki opened this issue Dec 17, 2014 · 2 comments · Fixed by #1528
Closed

Cop warning about capybara debug methods #1507

lloeki opened this issue Dec 17, 2014 · 2 comments · Fixed by #1528

Comments

@lloeki
Copy link
Contributor

lloeki commented Dec 17, 2014

Capybara has a few debug methods such as save_and_open_page and save_and_open_screenshot. It would be useful to have rubocop warn about this, similarly to binding.pry.
@rrosenblum
Copy link
Contributor

I do not have much experience with capybara, but this sounds easy enough to implement as long as those are the only methods to look out for. If you do not mind looking over it/testing it, I can create a pull request.

@bbatsov
Copy link
Collaborator

bbatsov commented Dec 25, 2014

Sure.

On Thursday, December 25, 2014, Ryan notifications@github.com wrote:

I do not have much experience with capybara, but this sounds easy enough
to implement as long as those are the only methods to look out for. If you
do not mind looking over it/testing it, I can create a pull request.

—
Reply to this email directly or view it on GitHub
#1507 (comment).

@rrosenblum rrosenblum mentioned this issue Dec 25, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configure Debugger cop to check for Capybara debug methods rrosenblum/rubocop
3 participants
@lloeki @bbatsov @rrosenblum