rubocop -a bug: Hash + comment

[dcu]

The following program:

def foo(opts = {})
  r = opts.merge({
    p1: opts[:a],
    p2: (opts[:b] || opts[:c]) # a comment
  })

  return r
end

converted to:

def foo(opts = {})
  r = opts.merge(    p1: opts[:a],
    p2: (opts[:b] || opts[:c]) # a comment)

  return r
end

[jonas054]

I'm considering a generic solution that stops any auto-correct from creating files with syntax errors in them. Is that a good idea or not? Are we hiding bugs if we do it like that?

[dcu]

Errors are fine, I mean I found a couple in a large codebase and they were easy to fix .
I reported them to make the feature better and if you hide them you won't get that.

[bbatsov]

I'm considering a generic solution that stops any auto-correct from creating files with syntax errors in them. Is that a good idea or not? Are we hiding bugs if we do it like that?

We'll probably hide the bugs this way (would you report a ticket for something that's not causing you problems?). I think the current model works just fine - if something's wrong we have to correct it.

[jonas054]

Good. I'll make a solution for this particular problem only.