Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint/UnneededDisable doesn't show cop name when -D is used #1958

Closed
jfelchner opened this issue Jun 9, 2015 · 1 comment
Closed

Lint/UnneededDisable doesn't show cop name when -D is used #1958

jfelchner opened this issue Jun 9, 2015 · 1 comment
Assignees
@jonas054
Labels
bug

Comments

@jfelchner
Copy link
Contributor

All cops show the cop name when the -D flag is used on the command line but for some reason the Lint/UnneededDisable cop doesn't.
@jonas054 jonas054 added the bug label Jun 9, 2015
@jonas054 jonas054 self-assigned this Jun 9, 2015
bbatsov added a commit that referenced this issue Jun 10, 2015
@bbatsov
Merge pull request #1961 from jonas054/1958_display_unneeded_disable_…
ce9e82e 
…name

[Fix #1958] Show Lint/UnneededDisable for --display-cop-names
@jfelchner
Copy link
Contributor Author

@jonas054 amazing as always sir!

Also I know I dropped a couple bugs on it, but I think that Lint/UnneededDisable is one of the best cops added in a long time. It found almost two dozen unneeded disables in my code. Excellent work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonas054 jonas054

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfelchner @jonas054