Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect extra space before expression modifier keywords #2008

Closed
bbatsov opened this issue Jul 2, 2015 · 1 comment
Closed

Detect extra space before expression modifier keywords #2008

bbatsov opened this issue Jul 2, 2015 · 1 comment
Assignees
@jonas054

Comments

@bbatsov
Copy link
Collaborator

bbatsov commented Jul 2, 2015

Basically code like this should be flagged:

# two spaces before the if
puts 'hello'  if something

@jonas054 Will you take care of this?
@jonas054 jonas054 self-assigned this Jul 8, 2015
@jonas054
Copy link
Collaborator

jonas054 commented Jul 8, 2015

Yes, I hope to have some time to spare in a few days.

bbatsov added a commit that referenced this issue Jul 10, 2015
@bbatsov
Merge pull request #2027 from jonas054/2008_space_before_modifier_kw
d21990b 
[Fix #2008] Check for too many spaces in SpaceBeforeModifierKeyword
jonas054 added a commit to jonas054/rubocop that referenced this issue Jul 25, 2015
@jonas054
Revert "[Fix rubocop#2008] Check for too many spaces in SpaceBeforeMo…
32e1043 
…difierKeyword"

This reverts commit e380cf0.

Not needed now that Style/ExtraSpacing is enabled by default
and checks spacing before modifier keywords among other things.
This also means that extra spacing before modifier keywords
is allowed by default if it's used for alignment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonas054 jonas054

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbatsov @jonas054