Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResultCache's path should include RUBY_VERSION #2284

Closed
miquella opened this issue Sep 29, 2015 · 1 comment
Closed

ResultCache's path should include RUBY_VERSION #2284

miquella opened this issue Sep 29, 2015 · 1 comment

Comments

@miquella
Copy link
Contributor

The parser gem chooses which parser to use based on RUBY_VERSION. Because of this, it is possible, if the same version of rubocop is installed under two different versions of ruby on the same machine, to get different results from each. But because of the caching in rubocop 0.34, one set of results would be masked/hidden.

To work around this issue, RUBY_VERSION should be included in the ResultCache's path.
@jonas054
Copy link
Collaborator

I agree. There are some offenses that are not reported for all ruby versions, so we should add RUBY_VERSION to the path.

@bbatsov bbatsov closed this as completed in 52f9c59 Oct 5, 2015
bbatsov added a commit that referenced this issue Oct 5, 2015
@bbatsov
Merge pull request #2288 from miquella/2284_result_cache_ruby_version
564144a 
[Fix #2284] Ruby versions should not share result cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonas054 @miquella