performance/string_replacement broken autocorrect

[cthiel]

commit d4d6414 (or a change recently introduced in master) still seems to be producing wrong corrections. Also, the message displayed was a bit misleading.

I had code like:

  a = somestring.gsub(/\n/,'')

The cop mentioned:
C: Use delete instead of gsub.

auto-correct turned the code into:

  a = somestring.tr('\\n', '')

which is neither using delete, nor is is producing the expected (same) result.

[alexdowad]

I have a fix. Pushing it to my open PR now.

[rrosenblum]

Interesting issue. somestring.tr('\\n', '') and somestring.delete('\\n') would produce the same outcome and are nearly identical in efficiency. Thanks for the fix @alexdowad.

[alexdowad]

😄