ShadowingOuterLocalVariable and UnusedLocalVariable triggered by Regexp with named captures

[badal]

2 errors occurred:
An error occurred while ShadowingOuterLocalVariable cop was inspecting
...
An error occurred while UnusedLocalVariable cop was inspecting ...

0.9.0 (using Parser 2.0.0.beta9, running on ruby 1.9.3 i386-mingw32)

Both errors are triggered by the following line :

   if /(?<token>\w+)(?<setter>=?)/ =~ name.to_s && token_names.include?(token)

[yujinakayama]

I'm looking at this, but it probably takes some time to handle this because the named capture variables don't appear in the AST.

[bbatsov]

@yujinakayama Pretty sure @whitequark implemented support for them recently.

[badal]

@yujinakayama No problem : this occurs in a legacy project I am cleaning, and I do not think I'll keep those named captures...

[yujinakayama]

@bbatsov I cannot see any node for it in both AST and the document.

$ ruby-parse -V
ruby-parse based on parser version 2.0.0.beta10
$ ruby-parse -e '/(?<match>bar)/ =~ baz'
(match-with-lvasgn
  (regexp
    (str "(?<match>bar)")
    (regopt))
  (send nil :baz))

[whitequark]

@yujinakayama Eh? You're looking at this node: match-with-lvasgn. If you want just the variable names, parse the inner (str) with Regexp.new--that's how Parser extracts them. There will be only one child str node.

[yujinakayama]

@whitequark Oh I didn't even know Regexp#named_captures. Thanks.