Indentation consistency in arrays and hashes

[bquorning]

Consider the following example code:

a = {
  a: 4
}
puts a

b = {
    b: 5
}
puts b

c = [
  1, 2, 3,
  4
]
puts c

d = [
    5, 6, 7,
    8
]
puts d

Hash b and array d are clearly mis-indented, but Rubocop doesn’t see any offences.

[bbatsov]

Indeed. @jonas054 would you take a look at this?

[jonas054]

Certainly. I think a couple of new cops are needed. We already have AlignArray and AlignHash to check that elements in multi-line literals have the same indentation. The new cops could be called IndentArray and IndentHash. The IndentHash cop would enforce style a in the example above. IndentArraywould enforce style c by default, since that's consistent with the style guide, but it would be configurable to allow another style

e = [
     1, 2, 3,
     4
    ]

This is the style I get from my emacs settings, and it's been used quite a lot in the RuboCop source code.

[bbatsov]

@jonas054 I think that style e was actually caused by a bug in Emacs, that's fixed in 24.4. I'm OK with the idea for this being handled by new cops.

[jonas054]

Oh. I feel I have been misled by Emacs for some time.

Alright, I guess we don't need to make it configurable, then.

[bquorning]

Thank you.

Benjamin

On 15/02/2014, at 06.35, Jonas Arvidsson notifications@github.com wrote:

Closed #797 via b5651c1.

—
Reply to this email directly or view it on GitHub.

[bquorning]

No pressure, but when will the be available in the gem? Do you have a patch/minor release planned?

[bbatsov]

No specific date has been planned. I usually make a new feature release every 4-6 weeks. Expect a new version in the beginning of March. In the meantime you can build the gem from github manually.